feat: button hovers, less rounding, full bleed 50/50#10
Merged
Conversation
✅ Deploy Preview for bs-said-yes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR standardizes button styling and hover behavior, simplifies the ContentContainer API, and refactors the 50/50 content module into clearer white vs. tan (secondary) variants with updated layout and border radius.
Changes:
- Introduces a new
button/button-secondaryutility pattern and updates usages (including navigation, login, and skip-link buttons) to use size utilities (button-sm/md/lg) separately from base button styles, with improved hover and disabled states. - Refactors the
FiftyFiftymodule intoFiftyFiftyWhiteandFiftyFiftySecondarycomponents, including full-bleed behavior on secondary background, while keeping alignment behavior and CTA structure consistent. - Simplifies
ContentContainerby removing thepaddingprop, applying consistent horizontal padding by default, and cleaning up unused spacing CSS variables; adjusts rounding on hero and nav links to userounded-lg.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
app/pages/login.vue |
Updates the login submit button to use the new button button-md pattern so it picks up shared button styling and hover/disabled behavior. |
app/components/navigation/MobileMenu.vue |
Adjusts mobile menu nav link rounding to rounded-lg and ensures the CTA uses button button-lg for consistent button styling. |
app/components/navigation/MainNavigation.vue |
Updates main nav link rounding to rounded-lg and applies button button-md to the floating CTA link. |
app/components/modules/HomepageHero.vue |
Reduces hero image border radius from rounded-xl to rounded-lg to align with the new rounding system. |
app/components/modules/FiftyFiftyWhite.vue |
New white-background 50/50 layout component with preserved alignment behavior, updated rounded-lg image styling, and CTAs using button / button-secondary with button-md. |
app/components/modules/FiftyFiftySecondary.vue |
New tan/secondary-background 50/50 layout with full-bleed treatment, gradient overlay on the image, and CTAs using the new button utilities with appropriate alignment margins. |
app/components/modules/FiftyFifty.vue |
Simplifies the module to delegate to FiftyFiftySecondary when background === 'Tan' and FiftyFiftyWhite otherwise, keeping only the background computed. |
app/components/base/SkipLink.vue |
Ensures the skip link button uses button button-sm so it inherits the unified button styling. |
app/components/base/ContentContainer.vue |
Removes the padding prop and always applies px-side-mobile md:px-side, leaving grid as the only behavior flag. |
app/assets/css/main.css |
Removes unused spacing variables --spacing-side-sm and --spacing-side-offset now that all callers use the simplified padding model. |
app/assets/css/_component.css |
Redefines button utilities into a base button and button-secondary with new hover/disabled styles and transitions, and updates size utilities (button-sm/md/lg) to only control padding and font size. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.